Skip to content

Commit efbd4e6

Browse files
committed
Merge branch 'blawrence/py39' into 'master'
Drop python 3.9 and macOS 10.15 support See merge request minknow/pod5-file-format!449
2 parents 2ece58d + 428b709 commit efbd4e6

File tree

3 files changed

+29
-32
lines changed

3 files changed

+29
-32
lines changed

.gitlab-ci.yml

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ before_script:
2222
.parallel-py-versions:
2323
parallel:
2424
matrix:
25-
- PYTHON_VERSION: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
25+
- PYTHON_VERSION: ["3.10", "3.11", "3.12", "3.13", "3.14"]
2626

2727

2828
# ======================================
@@ -348,7 +348,9 @@ linux-aarch64-gcc9-release-build:
348348
- "lib_pod5*.whl"
349349

350350
osx-arm64-clang15-release-build:
351-
extends: [".build-osx-common"]
351+
extends:
352+
- .build-osx-common
353+
- .parallel-py-versions
352354
tags:
353355
- osx_arm64
354356
- xcode-15.3
@@ -357,16 +359,9 @@ osx-arm64-clang15-release-build:
357359
CONAN_PROFILE: "macos-aarch64-appleclang-15.0.jinja"
358360
CONAN_PROFILE_CPPSTD: 20
359361
CMAKE_ARGS: "-DCMAKE_OSX_ARCHITECTURES=arm64"
360-
parallel:
361-
matrix:
362-
- PYTHON_VERSION: ["3.9"]
363-
MACOSX_DEPLOYMENT_TARGET: "10.15"
364-
OUTPUT_SKU: "osx-10.15-arm64"
365-
FORCE_PYTHON_PLATFORM: macosx_11_0_arm64
366-
- PYTHON_VERSION: ["3.10", "3.11", "3.12", "3.13", "3.14"]
367-
MACOSX_DEPLOYMENT_TARGET: "11.0"
368-
OUTPUT_SKU: "osx-11.0-arm64"
369-
FORCE_PYTHON_PLATFORM: macosx_11_0_arm64
362+
MACOSX_DEPLOYMENT_TARGET: "14.0"
363+
OUTPUT_SKU: "osx-14.0-arm64"
364+
FORCE_PYTHON_PLATFORM: macosx_14_0_arm64
370365

371366

372367
# ======================================
@@ -626,35 +621,34 @@ conda_pytest:
626621
- python3 -m venv .venv/
627622
- source .venv/bin/activate
628623
script:
629-
- pip install ./${LIB_WHEEL_GLOB} pod5-*.whl
624+
- pip install ./${LIB_WHEEL_GLOB} pod5-*.whl setuptools
630625
- pip install -r ./benchmarks/image/requirements-benchmarks.txt
631-
- export SLOW_5_VERSION=v1.0.0
632626
- ./benchmarks/image/install_slow5.sh
633-
- export PATH="$(pwd)/slow5tools-${SLOW_5_VERSION}/:$PATH"
627+
- export PATH="$(pwd)/slow5tools-v1.3.0/:$PATH"
634628
- ./benchmarks/run_benchmarks.py ./test_data/ ./benchmark-outputs
635629

636630
benchmark-linux-x64:
637631
extends: [".benchmark"]
638-
image: ${CI_REGISTRY}/traque/ont-docker-base/ont-base-python:3.9
632+
image: ${CI_REGISTRY}/traque/ont-docker-base/ont-base-python:3.14
639633
tags:
640634
- linux
641635
needs:
642636
- linux-x64-gcc9-release-build
643637
- build-python-api
644638
variables:
645-
LIB_WHEEL_GLOB: "lib_pod5*cp39*.whl"
639+
LIB_WHEEL_GLOB: "lib_pod5*cp314*.whl"
646640

647641
benchmark-linux-aarch64:
648642
extends: [".benchmark"]
649-
image: ${CI_REGISTRY}/traque/ont-docker-base/ont-base-python:3.9
643+
image: ${CI_REGISTRY}/traque/ont-docker-base/ont-base-python:3.14
650644
tags:
651645
- linux_aarch64
652646
- high-cpu
653647
needs:
654648
- linux-aarch64-gcc9-release-build
655649
- build-python-api
656650
variables:
657-
LIB_WHEEL_GLOB: "lib_pod5*cp39*.whl"
651+
LIB_WHEEL_GLOB: "lib_pod5*cp314*.whl"
658652

659653

660654
# ======================================
@@ -1277,8 +1271,5 @@ mlhub:
12771271
}' \
12781272
${MLHUB_TRIGGER_URL}
12791273
when: manual
1280-
parallel:
1281-
matrix:
1282-
- PYTHON_VERSION:
1283-
- "3.9"
1284-
- "3.12"
1274+
extends:
1275+
- .parallel-py-versions

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313

1414
- Added missing licence files.
1515

16+
### Removed
17+
18+
- Removed Python 3.9 and macOS 10.15 support since they're EOL.
19+
1620

1721
## [0.3.35]
1822

benchmarks/image/install_slow5.sh

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,32 +2,34 @@
22

33
set -e
44

5-
: "${SLOW_5_VERSION:=v1.0.0}"
5+
: "${SLOW_5_TOOLS_VERSION:=v1.3.0}"
6+
: "${SLOW_5_LIB_VERSION:=v1.3.1}"
67

78
apt update
89
apt install -y libzstd-dev libhdf5-dev
910

10-
wget "https://github.com/hasindu2008/slow5tools/releases/download/$SLOW_5_VERSION/slow5tools-$SLOW_5_VERSION-release.tar.gz"
11-
tar xvf "slow5tools-${SLOW_5_VERSION}-release.tar.gz"
11+
wget "https://github.com/hasindu2008/slow5tools/releases/download/${SLOW_5_TOOLS_VERSION}/slow5tools-${SLOW_5_TOOLS_VERSION}-release.tar.gz"
12+
tar xvf "slow5tools-${SLOW_5_TOOLS_VERSION}-release.tar.gz"
13+
rm "slow5tools-${SLOW_5_TOOLS_VERSION}-release.tar.gz"
1214
(
13-
cd "slow5tools-${SLOW_5_VERSION}"
15+
cd "slow5tools-${SLOW_5_TOOLS_VERSION}"
1416
./configure
15-
make zstd=1
17+
make zstd=1 -j "$(nproc)"
1618
)
1719

1820
# pyslow5 must be built with zstd support for fair comparison (otherwise default zlib is slower than zstd)
19-
git clone -b "${SLOW_5_VERSION}" https://github.com/hasindu2008/slow5lib
21+
git clone -b "${SLOW_5_LIB_VERSION}" https://github.com/hasindu2008/slow5lib
2022

2123
(
2224
cd slow5lib/
2325

2426
echo "Installing numpy"
2527
pip install numpy
2628

27-
make pyslow5
29+
make pyslow5 -j "$(nproc)" 2> build_log.txt || (cat build_log.txt && exit)
2830
echo "Installing pyslow5"
2931
PYSLOW5_ZSTD=1 pip install dist/*.tar.gz
3032

3133
# adding slow5 C API benchmarks
32-
make zstd=1 && test/bench/build.sh
34+
make zstd=1 -j "$(nproc)" && test/bench/build.sh
3335
)

0 commit comments

Comments
 (0)