Merge pull request #227 from aqyuki/improve-assert-test-coverage

Improve the test coverage about `DefaultVerifier`

Author: nao1215

assert_test.go

@@ -1,10 +1,18 @@
 package spectest
 
 import (
+	"fmt"
 	"net/http"
 	"testing"
 )
 
+type mockTestingT struct{}
+
+func (m *mockTestingT) Errorf(format string, args ...interface{}) {}
+func (m *mockTestingT) Fatal(args ...interface{})                 {}
+func (m *mockTestingT) Fatalf(format string, args ...interface{}) {}
+func (m *mockTestingT) Name() string                              { return "mock" }
+
 func TestApiTestAssertStatusCodes(t *testing.T) {
 	tests := []struct {
 		responseStatus []int
@@ -30,3 +38,215 @@ func TestApiTestAssertStatusCodes(t *testing.T) {
 		}
 	}
 }
+
+func Test_DefaultVerifier_True(t *testing.T) {
+	t.Parallel()
+	verifier := &DefaultVerifier{}
+	mock := &mockTestingT{}
+	tests := []struct {
+		name string
+		args bool
+		want bool
+	}{
+		{
+			name: "should return true",
+			args: true,
+			want: true,
+		},
+		{
+			name: "should return false",
+			args: false,
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			actual := verifier.True(mock, tt.args)
+			if actual != tt.want {
+				t.Fatalf("Expected %t but received %t", actual, tt.want)
+			}
+		})
+	}
+}
+
+func Test_DefaultVerifier_JSONEq(t *testing.T) {
+	t.Parallel()
+
+	verifier := &DefaultVerifier{}
+	mock := &mockTestingT{}
+
+	type args struct {
+		expected string
+		actual   string
+	}
+
+	tests := []struct {
+		name string
+		args args
+		want bool
+	}{
+		{
+			name: "should return true",
+			args: args{
+				expected: `{"name":"John","age":30,"car":null}`,
+				actual:   `{"name":"John","age":30,"car":null}`,
+			},
+			want: true,
+		},
+		{
+			name: "should failure with different values",
+			args: args{
+				expected: `{"name":"John","age":30,"car":null}`,
+				actual:   `{"name":"John","age":31,"car":null}`,
+			},
+			want: false,
+		},
+		{
+			name: "should failure to parse expected",
+			args: args{
+				expected: `{"name":"John","age":30,"car":null`,
+				actual:   `{"name":"John","age":30,"car":null}`,
+			},
+			want: false,
+		},
+		{
+			name: "should failure to parse actual",
+			args: args{
+				expected: `{"name":"John","age":30,"car":null}`,
+				actual:   `{"name":"John","age":30,"car":null`,
+			},
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			actual := verifier.JSONEq(mock, tt.args.expected, tt.args.actual)
+			if actual != tt.want {
+				t.Fatalf("Expected %t but received %t", actual, tt.want)
+			}
+		})
+	}
+}
+
+func Test_DefaultVerifier_Equal(t *testing.T) {
+	t.Parallel()
+
+	verifier := &DefaultVerifier{}
+	mock := &mockTestingT{}
+
+	var notOperationFunc = func() {}
+
+	type args struct {
+		expected interface{}
+		actual   interface{}
+	}
+
+	tests := []struct {
+		name string
+		args args
+		want bool
+	}{
+		{
+			name: "should return true",
+			args: args{
+				expected: 1,
+				actual:   1,
+			},
+			want: true,
+		},
+		{
+			name: "should return false because not operation function was given",
+			args: args{
+				expected: notOperationFunc,
+				actual:   notOperationFunc,
+			},
+			want: false,
+		},
+		{
+			name: "should return false because different values",
+			args: args{
+				expected: 1,
+				actual:   2,
+			},
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			actual := verifier.Equal(mock, tt.args.expected, tt.args.actual)
+			if actual != tt.want {
+				t.Fatalf("Expected %t but received %t", actual, tt.want)
+			}
+		})
+	}
+}
+
+func Test_DefaultVerifier_Fail(t *testing.T) {
+	t.Parallel()
+
+	verifier := &DefaultVerifier{}
+	mock := &mockTestingT{}
+
+	tests := []struct {
+		name string
+		args []interface{}
+		t    TestingT
+	}{
+		{
+			// FIXME: change the name of this test more better
+			name: "pat1",
+			args: []interface{}{},
+			t:    mock,
+		},
+		{
+			name: "pat2",
+			args: []interface{}{"foo"},
+			t:    mock,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			res := verifier.Fail(tt.t, tt.name, tt.args...)
+			if res {
+				t.Fatal("Expected false but received true")
+			}
+		})
+	}
+}
+
+func Test_DefaultVerifier_NoError(t *testing.T) {
+	t.Parallel()
+
+	verifier := &DefaultVerifier{}
+	mock := &mockTestingT{}
+
+	tests := []struct {
+		name string
+		args error
+		want bool
+	}{
+		{
+			name: "should return true",
+			args: nil,
+			want: true,
+		},
+		{
+			name: "should return false",
+			args: fmt.Errorf("error"),
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			actual := verifier.NoError(mock, tt.args)
+			if actual != tt.want {
+				t.Fatalf("Expected %t but received %t", actual, tt.want)
+			}
+		})
+	}
+}