fix: issue 36: Unable to connect to mysql with native password

[nao1215]

Summary by CodeRabbit

• New Features
  • Enhanced MySQL connectivity by enabling native password authentication, which can improve compatibility and reliability.

[coderabbitai]

Walkthrough

The pull request updates the NewMySQLDB function in config/database.go by adding a new boolean field, AllowNativePasswords, to the MySQL configuration structure. The field is set to true, enabling native password authentication for MySQL connections. Additionally, the formatting of existing configuration fields (DBName, User, Passwd, Addr, Net, ParseTime, and Collation) has been standardized, without changing their values or affecting the overall logic.

Changes

File(s)	Change Summary
config/database.go	Updated NewMySQLDB function: added the new boolean field AllowNativePasswords (set to true) to the mysql.Config struct; standardized formatting for fields.

Poem

I'm a rabbit in a code-filled glen,
Hopping through changes with a pen.
A new field shines, true and bright,
In MySQL configs, it's a fresh sight.
With carrots and code, I cheer with glee—
Happy hops and coding, for all to see!
🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66346bb and 4bc3ba6.

📒 Files selected for processing (1)

• config/database.go (1 hunks)

🔇 Additional comments (1)

config/database.go (1)

106-114:

✅ Verification successful

Good fix for the MySQL native password authentication issue.

The addition of AllowNativePasswords: true will fix the connection issues when the MySQL server is configured to use native password authentication. This is a common compatibility solution when connecting to MySQL servers. The formatting improvements for field alignment also enhance code readability.

---

🏁 Script executed:

#!/bin/bash
# Verify the version of go-sql-driver/mysql being used

grep -A 5 "github.com/go-sql-driver/mysql" go.mod || echo "go-sql-driver/mysql not found in go.mod"

# Check if any unit tests for database connections exist
echo "Checking for database connection tests:"
fd "database.*test.go" -t f

Length of output: 402

---

Confirmation of MySQL Native Password Fix and Test Coverage

The recent review comment is validated by the gathered results:

• Dependency Version: The project is using github.com/go-sql-driver/mysql v1.9.1, which supports the use of native passwords.
• Unit Tests: The presence of config/database_test.go ensures that database connection functionalities, including the native password authentication scenario, are being tested.
• Code Changes: The change to include AllowNativePasswords: true in config/database.go correctly addresses the connection issues for MySQL servers set to use native password authentication, and the formatting improvements enhance readability.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Code Metrics Report

	main (66346bb)	#39 (e45e397)	+/-
Coverage	34.7%	34.7%	0.0%
Test Execution Time	40s	3s	-37s

Details

  |                     | main (66346bb) | #39 (e45e397) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |          34.7% |         34.7% | 0.0% |
  |   Files             |             27 |            27 |    0 |
  |   Lines             |            966 |           966 |    0 |
  |   Covered           |            336 |           336 |    0 |
+ | Test Execution Time |            40s |            3s | -37s |

Code coverage of files in pull request scope (10.9% → 10.9%)

Files	Coverage	+/-
config/database.go	10.9%	0.0%

---

Reported by octocov