Fix issue 43: Panic when importing json table with numeric field.

[nao1215]

Summary by CodeRabbit

• New Features

  • Enhanced JSON to table conversion to handle various data types more accurately.

• Bug Fixes

  • Resolved an issue causing a crash when importing JSON tables with numeric fields.

• Tests

  • Added new test cases to ensure stability and correctness of JSON imports.

[coderabbitai]

Warning

Rate Limit Exceeded

@nao1215 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 49 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 1b7dc74 and 6cbf62e.

Walkthrough

The update improves the handling of JSON data in the JSON struct's ToTable method by using a switch statement to manage various data types and converting float64 values to strings. Additionally, a new test case and test data address a specific bug where a panic occurred when importing JSON with numeric fields.

Changes

File	Change Summary
domain/model/json.go	Enhanced type handling in ToTable method; added float64 to string conversion
main_test.go	Added test case for handling numeric fields in JSON imports
testdata/bug_issue43.json	New JSON test data with numeric and string fields
testdata/golden/...	New golden file for test output verification

Possibly related issues

• Issue [BUG] Panic when importing json table with numeric field. #43: The changes directly address the panic described when importing a JSON table with a numeric field, thus resolving the bug reported.

🐇✨
In the code where data flows,
A rabbit hopped, fixing woes.
Numbers danced, strings aligned,
No more errors for us to find.
Celebrate, for bugs are few,
Thanks to the updates we pursue! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[github-actions]

HOTTEST report

PASS	FAIL	SKIP	TOTAL	DURATION
183	0	0	183	35.852843437s

---

Reported by hottest

[github-actions]

Code Metrics Report

	main (270fd41)	#47 (dfb53e3)	+/-
Coverage	86.1%	86.0%	-0.1%
Test Execution Time	47s	43s	-4s

Details

  |                     | main (270fd41) | #47 (dfb53e3) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          86.1% |         86.0% | -0.1% |
  |   Files             |             35 |            35 |     0 |
  |   Lines             |            835 |           837 |    +2 |
+ |   Covered           |            719 |           720 |    +1 |
+ | Test Execution Time |            47s |           43s |   -4s |

Code coverage of files in pull request scope (95.7% → 92.0%)

Files	Coverage	+/-
domain/model/json.go	92.0%	-3.7%

---

Reported by octocov