Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float speed #33

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MeggyCal
Copy link

the package didn't build for me (tests failed, don't know why) and I managed to fix it with something similar to napalm-automation-community/napalm-arubaos-switch@ebd48e4.

Please note: I don't know what it does (sorry), I am just sending you the fix hoping it could prove useful at some point.

the 'speed' parameter needs to be float
@MeggyCal
Copy link
Author

MeggyCal commented Aug 25, 2022

Just adding the previous test result:

[   63s] =================================== FAILURES ===================================
[   63s] ____________________ TestGetter.test_get_interfaces[normal] ____________________
[   63s] 
[   63s] self = <test_getters.TestGetter object at 0xf413aa90>, test_case = 'normal'
[   63s] 
[   63s]     @wrap_test_cases
[   63s]     def test_get_interfaces(self, test_case):
[   63s]         """Test get_interfaces."""
[   63s]         get_interfaces = self.device.get_interfaces()
[   63s]         assert len(get_interfaces) > 0
[   63s]     
[   63s]         for interface, interface_data in get_interfaces.items():
[   63s] >           assert helpers.test_model(models.interface, interface_data)
[   63s] E           AssertionError
[   63s] 
[   63s] /usr/lib/python3.8/site-packages/napalm/base/test/getters.py:161: AssertionError
[   63s] ----------------------------- Captured stdout call -----------------------------
[   63s] key: speed
[   63s] model_class: <class 'float'>
[   63s] data_class: <class 'int'>
[   63s] key: mac_address
[   63s] model_class: <class 'str'>
[   63s] data_class: <class 'str'>

The commit above fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant