This repository has been archived by the owner on Feb 10, 2018. It is now read-only.
Added commit confirm functionality #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceaulinic
approved these changes
Mar 3, 2017
There was a problem hiding this comment.
This looks good to me. Thanks @kderynski!
Can you please confirm that it does not change the current behaviour? (calling commit_config() without any args commits directly?).
|
Hey @mirceaulinic, Yes, I have tested it. BTW I will create PR in a few minutes with brief description of this method in documentation. |
|
Looking at this, I'd like to test the following scenario:
|
|
@mirceaulinic I have tested proposed scenario and config DB was unlocked during commit confirmed period. I have added small fix and now it works as it should, so config DB is locked when device waits for confirmation. |
|
Thanks @kderynski |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to napalm-automation/napalm-base#213