Add short guide on updating constraints files #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
There is already such an action https://github.com/napari/napari/blob/main/.github/workflows/upgrade_test_constraints.yml |
|
But that is for tests only, right? |
No, it generates PRs like this napari/napari#7045 |
jni
pushed a commit
to napari/napari
that referenced
this pull request
Jul 22, 2024
) # References and relevant issues Follow-up to napari-sphinx-theme release 0.5.0. # Description Updates docs constraints file for python 3.10, also adds a constraints file for docs on python 3.11. I am not sure if I'm doing things right, but would love to learn. I am also submitting a docs PR to detail this process in the core developers guide. UPDATE: napari/docs#460 Co-authored-by: Peter Sobolewski <[email protected]>
|
Should we also add the bot usage here, and @Czaki does the bot work in the docs repo? |
|
Hi folks, not sure what the next step is here. Maybe we should close since the action runs automatically? |
Czaki
previously requested changes
Aug 16, 2024
melissawm
force-pushed
the
howto-constraints
branch
from
92da5eb to
1dc0756
Compare
|
Updated, thanks @Czaki ! |
Czaki
dismissed
their stale review
will try to find time later but not want to block
psobolewskiPhD
approved these changes
Aug 17, 2024
|
Thanks @melissawm ❤️ |
|
Hi friends, any last comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
N/A
Description
Adds a short guide on updating the constraints files for core developers. I wonder if we should automate this with a bot or action (expanding the update test constraints action perhaps?)