move return part out of finally block#75
Merged
DragaDoncila merged 1 commit intonapari:mainfrom Feb 10, 2026
Merged
Conversation
Contributor
Author
|
@DragaDoncila please sanity check this! Assuming this is even needed since we're dropping npe1 stuff in the same release? |
DragaDoncila
approved these changes
Feb 8, 2026
Contributor
DragaDoncila
left a comment
DragaDoncila
left a comment
There was a problem hiding this comment.
@brisvag this looks fine to me. We use napari-plugin-engine for the translations stuff, which I don't remove in napari/napari#8622, so I think we should include this PR for now. We'll need a release, right?
Contributor
Author
|
👍 Yep, we can release straight away, this is a good change no matter what. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bumping napari to python 3.14, this triggers a syntax warning, due to PEP 765.
This should be the correct fix.