Skip to content

Change suffix of conda executable form .bat to .exe #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Apr 25, 2025

Closes napari/packaging#233

As I checked the bundle installation for napari 0.6.0rc0, the conda.bat is not available, but conda.exe is.

Checked locally that change of suffix from .bat to .exe solves the problem for me.

For Windows, the .exe file is just a binary executable. The .bat is windows script. I do not see the advantage of .bat over .exe to prefer .bat.

@Czaki Czaki requested a review from jni April 25, 2025 08:30
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@jni
Copy link
Member

jni commented Apr 25, 2025

@Czaki is it worth checking for both? Since the plugin manager was working fine when installing napari from conda rather than the bundle...?

@Czaki
Copy link
Contributor Author

Czaki commented Apr 25, 2025

I do not have anaconda/Conda environment on my Windows machine. As I remember from the past, the conda installation contains both conda.bat and conda.exe

Also, this function returns a name that is expected to be present on the PATH, we do not check if it exists. I may try to write code that will try to traverse through PATH to check if the file exists.

@TimMonko
Copy link
Contributor

Is the problem that there is not .bat? I think I was able to find one. I think the problem is that the path is pointing towards a temp file. Though I think the behavior was different between 0.5.4 and 0.5.6. I know my comments are long and rambling in the issue, but I thought I wrote about this somewhere. Maybe not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows, Bundle] Unable to install plugins via conda (default)
3 participants