Skip to content

Refresh Token Issuing for new Kafka Clients #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dakota002
Copy link
Contributor

Resolves #2991

This adds:

  • Table for storing refresh tokens
  • Python sample code update (behind TOKEN_AUTH flag)
  • Token Generation Credential form and card UI (behind TOKEN_AUTH flag)
  • Scoped login behavior to get tokens bound to single scope

Still needs to:

  • Update sample code for other languages
  • Finish up UI and CRUD behavior for stored tokens

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 2.51572% with 155 lines in your changes missing coverage. Please review.

Project coverage is 6.39%. Comparing base (8cace87) to head (610dcf2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/components/NewCredentialForm.tsx 0.00% 48 Missing ⚠️
app/routes/_auth.login.ts 0.00% 16 Missing ⚠️
app/routes/_auth/user.server.ts 0.00% 16 Missing ⚠️
app/routes/user.credentials._index.tsx 0.00% 15 Missing ⚠️
app/lib/cognito.server.ts 14.28% 12 Missing ⚠️
app/components/RefreshTokenCard.tsx 0.00% 10 Missing ⚠️
app/routes/quickstart.code.tsx 0.00% 10 Missing ⚠️
app/routes/_auth/auth.server.ts 0.00% 8 Missing ⚠️
app/routes/quickstart.credentials.tsx 0.00% 8 Missing ⚠️
app/routes/user.token.$tokenId.ts 0.00% 6 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3095      +/-   ##
========================================
- Coverage   6.51%   6.39%   -0.13%     
========================================
  Files        179     181       +2     
  Lines       4422    4552     +130     
  Branches     486     503      +17     
========================================
+ Hits         288     291       +3     
- Misses      4132    4259     +127     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Get the client Id programmatically

Adds token revokation/delete

Updating sample code

Maybethrow for the clientId

Adds encryption to table, don't pass token, use Id instead

Breaks out the download to ensure user is signed in and not include it in the page content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website Backend Updates for Refresh Tokens
1 participant