DO NOT MERGE/gather event ids to repair #3149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
========================================
- Coverage 6.56% 6.48% -0.08%
========================================
Files 176 180 +4
Lines 4389 4439 +50
Branches 481 489 +8
========================================
Hits 288 288
- Misses 4099 4149 +50
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lpsinger
requested changes
Jun 17, 2025
| function processFiles() { | ||
| const folderPath = './app/archive.json' | ||
| const results = [] as UpdateData[] | ||
| fs.readdir(folderPath, (err, files) => { |
There was a problem hiding this comment.
Please use the fs/promises module and async/await syntax over the fs module and callback syntax.
| console.error('Error reading directory:', err) | ||
| return | ||
| } | ||
| files.forEach((file) => { |
There was a problem hiding this comment.
Please use:
result = input.map((item) => ...)rather than:
const results = []
input.forEach((...) => {results.push(...)})| } | ||
|
|
||
| function processFiles() { | ||
| const folderPath = './app/archive.json' |
There was a problem hiding this comment.
Where does this file, archive.json, come from? Our downloadable archive is a tarball of JSON files, not one big JSON file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a script that uses the subject matchers in the app to go through the archive and find circulars that need to have their eventId's updated or corrected. Detailed instructions on how to use this script are found at the top of the script file.
Related Issue(s)
Resolves #3061
Testing
I have run this locally.