Skip to content

Conversation

knickels
Copy link
Contributor

I'm adding my notes as I do this build. Does it make sense to batch them into a single PR?

Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great additions as is - appreciate your contributions!
Smaller, frequent PRs tend to work better and mean that if one PR is stuck in review, other changes can make it in faster.
@abust005 @apollokit any comments or good to merge?

@abust005
Copy link
Collaborator

These are great additions as is - appreciate your contributions! Smaller, frequent PRs tend to work better and mean that if one PR is stuck in review, other changes can make it in faster. @abust005 @apollokit any comments or good to merge?

Good changes, I say good to merge. Glad that some of the TODOs are gone, I hadn't even noticed them (highway blindness, I guess)

@knickels
Copy link
Contributor Author

I see the docs/readthedocs.org job failed, but it looks like an upstream config issue. Is that something I need to worry about?

@knickels
Copy link
Contributor Author

Marking as ready for review. I've finished with the harnesses and the motor board build.

@knickels knickels marked this pull request as ready for review September 26, 2025 20:48
@Achllle Achllle merged commit de04470 into nasa-jpl:master Sep 27, 2025
1 of 2 checks passed
@Achllle
Copy link
Collaborator

Achllle commented Sep 27, 2025

Thank you!
The readthedocs build task failure is unrelated. It is due for an update but low priority since few people seem to use it.

andreabenini added a commit to andreabenini/jpl-open-source-rover that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants