Skip to content

Conversation

@eereiter
Copy link
Contributor

Overview

What is the feature/fix?

When a subscription is created or deleted update the subscription cache so that granule ingest subscriptions can be filtered out quickly.

What is the Solution?

Changed Metadata_db concept_service and subscriptions to call to cache or remove subscription information needed to get granule CRUD events for notifications.

What areas of the application does this impact?

Metadata_db concept_service and subscriptions

Checklist

  • [Z] I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

(ingest-events/publish-event
context (ingest-events/concept-delete-event revisioned-tombstone)))
(subscriptions/delete-subscription context concept-type revisioned-tombstone)
(subscriptions/change-subscription context concept-type revisioned-tombstone)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove delete and replace with change?

@eereiter eereiter closed this Oct 22, 2024
@eereiter eereiter deleted the CMR-10140 branch October 22, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants