[nasa/cryptolib#441] Set Key, MC, SA, and Crypto type at compile time…

[Donnie-Ice]

…, use those defines in UTs

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

• Does your submission pass tests?

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

This should allow every UT to run on every build type. You should be able to see each of the added build flags at the beginning of the build script step in CI.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 94.89051% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (14ee573) to head (5e1ce87).
Report is 147 commits behind head on dev.

Files with missing lines	Patch %	Lines
test/unit/ut_sadb_err_cases_kmc_crypto.c	0.00%	4 Missing ⚠️
src/core/crypto_config.c	75.00%	1 Missing ⚠️
test/unit/ut_mysql_m_tls_connection.c	0.00%	1 Missing ⚠️
test/unit/ut_mysql_tls_connection.c	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #443      +/-   ##
==========================================
- Coverage   75.97%   75.79%   -0.19%     
==========================================
  Files          81       80       -1     
  Lines       22263    22812     +549     
  Branches     1807     1845      +38     
==========================================
+ Hits        16914    17290     +376     
- Misses       4707     4850     +143     
- Partials      642      672      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Donnie-Ice]

This causes every UT file to show errors, but it does work. Not sure if there is a way to ignore warnings for undefined constants

[Donnie-Ice]

We have been told that this type of "one crypto type, one key type, ..." is not ideal and they would like to be able to change. I believe this only affect unit tests, so this may still be ok.

[dccutrig]

@Donnie-Ice Are we good to proceed on evaluating some of these PRs now? I know we were holding for JPL until their most recent release.

[Donnie-Ice]

Yep, they said we’re good to go.

…

On Mon, May 12, 2025 at 2:37 PM dccutrig ***@***.***> wrote: *dccutrig* left a comment (nasa/CryptoLib#443) <#443 (comment)> @Donnie-Ice <https://github.com/Donnie-Ice> Are we good to proceed on evaluating some of these PRs now? I know we were holding for JPL until their most recent release. — Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASR6XZP36F54QNQNDRVLV5T26DS5ZAVCNFSM6AAAAABZ2TA4HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZTGYZDAOBXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jlucas9]

Should we update a unit test to test multiple configurations back to back to prove this functionality?

[Donnie-Ice]

Should we update a unit test to test multiple configurations back to back to prove this functionality?

Sorry, just saw this. The CI runners prove this, although I believe wolfssl build script is currently using libgcrypt in dev. Can't remember why, but most likely due to some kind of segfault issues.