Skip to content

Fix bug in handling of qualified names #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

bocchino
Copy link
Collaborator

When computing a short name, the system was reversing the list of qualifiers in the prefix.

  • Fix bug
  • Update unit tests to exercise the correct behavior

Closes #453.

Update unit tests to check for the issue
@bocchino bocchino requested a review from jwest115 June 25, 2024 04:37
Copy link
Collaborator

@jwest115 jwest115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@bocchino bocchino merged commit 41c344a into main Jun 25, 2024
11 checks passed
@bocchino bocchino deleted the issue-453-qualified-names branch June 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qualified Identifiers for nested modules are incorrect in TopologyAc.hpp and TopologyAc.cpp
2 participants