Skip to content

Remove use of PROTECTED, PRIVATE #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

m-aleem
Copy link
Collaborator

@m-aleem m-aleem commented Jun 27, 2025

In support of #3446, remove use of PROTECTED and PRIVATE (STATIC already unsused)

@bocchino
Copy link
Collaborator

bocchino commented Jul 8, 2025

@m-aleem Is the next step here to create an alpha release of FPP, integrate it with F Prime, and remove PRIVATE and PROTECTED completely from F Prime? If so, I will go ahead and create the alpha release.

@m-aleem
Copy link
Collaborator Author

m-aleem commented Jul 8, 2025

@bocchino Yes, we need an FPP alpha release + we also need to merge nasa/fprime#3810

Here is my recommended series of steps at this point:

  1. Review + Merge Pull Request Updates for FPPTest corresponding to UT cmake update for protected/private fprime#3810: Updates in FppTest, doesn’t need FPP alpha release
  2. FPP alpha release + integrate it with F Prime that includes Add state machine Tester friend #753
  3. Review + Merge Pull Request Reset PROTECTED/PRIVATE/STATIC override flags fprime#3815: Update -D macro flags to private/protected/static, checks from this ensure we’re actually ok without the override flags being removed
  4. Review + Merge Pull Request Remove use of PROTECTED, PRIVATE #754: Remove PROTECTED and PRIVATE from FPP
  5. FPP alpha release + integrate it with F Prime that includes Remove use of PROTECTED, PRIVATE #754
  6. Review + Merge Pull Request Remove PRIVATE PROTECTED and STATIC access overrides fprime#3821: Actually remove -D<PRIVATE/PROTECTED/STATIC> macros & documentation, relies on FPP alpha release from previous step
  7. Review + Merge Pull Request Removal of PRIVATE/PROTECTED/STATIC pre/post-process fprime-tools#267: Remove PRIVATE/PROTECTED/STATIC from fprime-tools

@bocchino
Copy link
Collaborator

bocchino commented Jul 9, 2025

Sounds good, thanks! I would like to go over nasa/fprime#3810 at our next regular meeting. It looks good to me so far, but I want to make sure I understand the patterns used to make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants