Skip to content

InT to load a deployment specific config file and provide necessary mapping #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 18, 2025

Conversation

ekswang
Copy link
Contributor

@ekswang ekswang commented Jun 10, 2025

Related Issue(s) 3213
Has Unit Tests (y/n) N/A
Documentation Included (y/n) Y

Change Description

Adding a feature to pytest to load a deployment configuration file with a list of deployment configurations. This configuration will list the instance names of F Prime components and the file path to parameter db.

  • component instance name: get_mnemonic()
  • file path to parameter db: get_prm_db_path()

API change:

  • get_deployment() - updated to use metadata info in the loaded dictionary rather than using dictionary path

Rationale

Component instance names can be different across different deployments. As we start developing InT scripts for each component, we'll need to implement them while being deployment agnostic. The InT scripts will utilize the configuration JSON file to know component's instance name and file path to parameter db. This is different than the current approach to hard-coding the instance name in the InT script.

Testing/Review Recommendations

Ran pytest to check the loading of the the deployment configuration file using defined --deployment-config flag. Additional tests were performed using this feature as part of InT testing.

Future Work

N/A

@thomas-bc thomas-bc requested a review from kevin-f-ortega June 10, 2025 19:33
Copy link
Collaborator

@kevin-f-ortega kevin-f-ortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@kevin-f-ortega kevin-f-ortega requested a review from thomas-bc June 11, 2025 01:18
kevin-f-ortega
kevin-f-ortega previously approved these changes Jun 11, 2025
@LeStarch LeStarch merged commit 73e6942 into nasa:devel Jun 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants