-
Notifications
You must be signed in to change notification settings - Fork 47
InT to load a deployment specific config file and provide necessary mapping #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
requested changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you
kevin-f-ortega
previously approved these changes
Jun 11, 2025
thomas-bc
reviewed
Jun 11, 2025
LeStarch
requested changes
Jun 11, 2025
LeStarch
approved these changes
Jun 12, 2025
LeStarch
requested changes
Jun 12, 2025
thomas-bc
reviewed
Jun 16, 2025
thomas-bc
approved these changes
Jun 18, 2025
LeStarch
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Adding a feature to pytest to load a deployment configuration file with a list of deployment configurations. This configuration will list the instance names of F Prime components and the file path to parameter db.
API change:
Rationale
Component instance names can be different across different deployments. As we start developing InT scripts for each component, we'll need to implement them while being deployment agnostic. The InT scripts will utilize the configuration JSON file to know component's instance name and file path to parameter db. This is different than the current approach to hard-coding the instance name in the InT script.
Testing/Review Recommendations
Ran pytest to check the loading of the the deployment configuration file using defined
--deployment-config
flag. Additional tests were performed using this feature as part of InT testing.Future Work
N/A