Skip to content

ix: added buffer boundary checking to event decoder + improve exception handling in event distributor #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

Aderiani
Copy link

…ion handling in event distributor

**Related Issue(s) Event decoder crashes on packets shorter than expected #3789 DecodingException import scope causes secondary failures #3790
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

  1. Event Parser Robustness (High Priority)
    File: fprime_gds/common/decoders/event_decoder.py
    Problem: Parser crashes on malformed/short packets
    Fix: Add buffer boundary checking
  2. Exception Handling (Medium Priority)
    File: fprime_gds/common/distributor/distributor.py
    Problem: DecodingException import scope issues
    Fix: Proper exception handling
  3. Cross-Platform Compatibility (Medium Priority)
    Files: Event decoders
    Problem: Poor handling of endianness/structure differences
    Fix: More robust parsing with fallbacks

Rationale

Fixes bugs Event decoder crashes on packets shorter than expected #3789 DecodingException import scope causes secondary failures #3790

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

@Aderiani Aderiani requested review from LeStarch and thomas-bc June 26, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants