-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CCSDS AOS Framer #4630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Willmac16
wants to merge
32
commits into
nasa:devel
Choose a base branch
from
Willmac16:aos-framing
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CCSDS AOS Framer #4630
+1,407
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Only uncovered line is the (not yet implemented) EPP Idle packet generation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Implements a CCSDS AOS Framer that supports both many packets per frame and packets than span multiple frames.
Rationale
AOS is a newer protocol than TM (although USLP is even newer). Requiring one packet per frame is inefficient and overly limits the size of packets that can be sent.
Testing/Review Recommendations
Ensure code style, layout and coverage looks good. Determine if existing subset of AOS features would be sufficient for Fprime downlink.
Future Work
An AOS Deframer will be made to accompany this, and AOS gds infrastructure will also likely be added.
AI Usage (see policy)
N/A