Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate Parameter ipynb #72

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Estimate Parameter ipynb #72

merged 2 commits into from
Aug 10, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Aug 7, 2023

Add estimate parameters jupyter notebook (from prog_models nasa/prog_models#540, by @aqitya).

Only change is change prog_models to progpy.

Will merge at the first approval

@teubert teubert added the documentation Improvements or additions to documentation, examples, or tutorial label Aug 7, 2023
@teubert teubert requested review from kjjarvis and aqitya August 7, 2023 23:20
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

Codecov Report

Merging #72 (21f06c7) into dev (7e9b223) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #72   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          99       99           
  Lines       10111    10111           
=======================================
  Hits         8513     8513           
  Misses       1598     1598           

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new notebook from @aqitya.

@teubert teubert merged commit 61ba4f6 into dev Aug 10, 2023
29 of 30 checks passed
@teubert teubert deleted the tests/estimate_params_ipynb branch August 16, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation, examples, or tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants