Refactor code to decl literals #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbielyman
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm getting acquainted with the ziglua codebase and noticed some potential refactorings so figured I'd open up some PRs (this is 1 of 2, for now).
This PR makes use of decl literals where possible. (Note that since most of the library surface area is interfacing with C, there's not a lot!)
Additionally, in the tests, all
var lua = try Lua.init(...)has been refactored from var to const (const lua: *Lua = try .init(...)), since the variable holding the pointer is never mutated, to avoid the situation where those using the tests as a reference implementation may copy the same pattern.