allow using system lua #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can you add lua 5.5 support, which was just released? |
Contributor
Author
|
Sorry, my distro doesn't have it yet so I can't test it, and ziglua itself doesn't support it yet either |
p00f
commented
Dec 25, 2025
| const zlua = b.addModule("zlua", .{ | ||
| const zlua = if (system) b.addModule("zlua", .{ | ||
| .root_source_file = b.path("src/lib.zig"), | ||
| .target = target, |
Contributor
Author
There was a problem hiding this comment.
we can't cross compile when using system lua so this should be fine
| .lua53 => zlua.linkSystemLibrary("lua5.3", .{ .preferred_link_mode = link_mode }), | ||
| .lua54 => zlua.linkSystemLibrary("lua5.4", .{ .preferred_link_mode = link_mode }), | ||
| .luajit => zlua.linkSystemLibrary("luajit", .{ .preferred_link_mode = link_mode }), | ||
| .luau => @panic("luau not supported for system lua"), |
Contributor
Author
There was a problem hiding this comment.
the luau package in my distro doesn't come with libraries or headers
robbielyman
approved these changes
Jan 5, 2026
Contributor
Author
|
@robbielyman can this be backported to a branch that works with zig 0.15? |
robbielyman
added a commit
that referenced
this pull request
Jan 7, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the zig bindings with system lua