KH firmware pre_133 does not support BMS registers

See #772
nathanmarlor · Feb 3, 2025 · 1241baa · 1241baa
1 parent 385beb0
commit 1241baa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 65 deletions.
diff --git a/custom_components/foxess_modbus/entities/entity_descriptions.py b/custom_components/foxess_modbus/entities/entity_descriptions.py
@@ -2131,29 +2131,29 @@ def _inner(
         ],
         bms_cell_temp_high=[
             ModbusAddressesSpec(input=[11043], models=Inv.H1_G1 | Inv.KH_PRE119),
-            ModbusAddressesSpec(holding=[37617], models=Inv.H1_G2_144 | Inv.KH_PRE133 | Inv.KH_133),
+            ModbusAddressesSpec(holding=[37617], models=Inv.H1_G2_144 | Inv.KH_133),
             # Temporarily removed, see #756
             # ModbusAddressesSpec(holding=[31102], models=Inv.H3_SET),
         ],
         bms_cell_temp_low=[
             ModbusAddressesSpec(input=[11044], models=Inv.H1_G1 | Inv.KH_PRE119),
-            ModbusAddressesSpec(holding=[37618], models=Inv.H1_G2_144 | Inv.KH_PRE133 | Inv.KH_133),
+            ModbusAddressesSpec(holding=[37618], models=Inv.H1_G2_144 | Inv.KH_133),
             # Temporarily removed, see #756
             # ModbusAddressesSpec(holding=[31103], models=Inv.H3_SET),
         ],
         bms_cell_mv_high=[
             ModbusAddressesSpec(input=[11045], models=Inv.H1_G1 | Inv.KH_PRE119),
-            ModbusAddressesSpec(holding=[37619], models=Inv.H1_G2_144 | Inv.KH_PRE133 | Inv.KH_133),
+            ModbusAddressesSpec(holding=[37619], models=Inv.H1_G2_144 | Inv.KH_133),
             # ModbusAddressesSpec(holding=[31100], models=Inv.H3_SET), provided in V * 10 aka 32 for 3200mV
         ],
         bms_cell_mv_low=[
             ModbusAddressesSpec(input=[11046], models=Inv.H1_G1 | Inv.KH_PRE119),
-            ModbusAddressesSpec(holding=[37620], models=Inv.H1_G2_144 | Inv.KH_PRE133 | Inv.KH_133),
+            ModbusAddressesSpec(holding=[37620], models=Inv.H1_G2_144 | Inv.KH_133),
             # ModbusAddressesSpec(holding=[31101], models=Inv.H3_SET), provided in V * 10 aka 32 for 3200mV
         ],
         bms_kwh_remaining=[
             ModbusAddressesSpec(input=[11037], models=Inv.H1_G1 | Inv.KH_PRE119),
-            ModbusAddressesSpec(holding=[37632], models=Inv.H1_G2_SET | Inv.KH_PRE133 | Inv.KH_133),
+            ModbusAddressesSpec(holding=[37632], models=Inv.H1_G2_SET | Inv.KH_133),
             # Temporarily removed, see #756
             # ModbusAddressesSpec(holding=[31123], models=Inv.H3_SET),
         ],

diff --git a/...apshots__/test_entity_descriptions/test_entity_descriptions_for_model[Inv.KH_PRE133].json b/...apshots__/test_entity_descriptions/test_entity_descriptions_for_model[Inv.KH_PRE133].json
@@ -109,54 +109,6 @@
     "signed": true,
     "type": "sensor"
   },
-  {
-    "addresses": {
-      "holding": [
-        37619
-      ]
-    },
-    "key": "bms_cell_mv_high",
-    "name": "BMS Cell mV High",
-    "scale": null,
-    "signed": false,
-    "type": "sensor"
-  },
-  {
-    "addresses": {
-      "holding": [
-        37620
-      ]
-    },
-    "key": "bms_cell_mv_low",
-    "name": "BMS Cell mV Low",
-    "scale": null,
-    "signed": false,
-    "type": "sensor"
-  },
-  {
-    "addresses": {
-      "holding": [
-        37617
-      ]
-    },
-    "key": "bms_cell_temp_high",
-    "name": "BMS Cell Temp High",
-    "scale": 0.1,
-    "signed": true,
-    "type": "sensor"
-  },
-  {
-    "addresses": {
-      "holding": [
-        37618
-      ]
-    },
-    "key": "bms_cell_temp_low",
-    "name": "BMS Cell Temp Low",
-    "scale": 0.1,
-    "signed": true,
-    "type": "sensor"
-  },
   {
     "addresses": {
       "holding": [
@@ -181,18 +133,6 @@
     "signed": false,
     "type": "sensor"
   },
-  {
-    "addresses": {
-      "holding": [
-        37632
-      ]
-    },
-    "key": "bms_kwh_remaining",
-    "name": "BMS kWh Remaining",
-    "scale": 0.01,
-    "signed": false,
-    "type": "sensor"
-  },
   {
     "addresses": {
       "holding": [