Add Peak Shaving work mode for H3 Inverters & H1 (Gen 2) #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pytest is failing on work mode even though the snapshots appear correct ? |
|
Always fails on Inv.H3 pytest --snapshot-update deletes the H3 file and doesn't recreate with the following error ? FAILED tests/test_entity_descriptions.py::test_entity_descriptions_for_model[Inv.H3] - RuntimeError: dictionary keys changed during iteration |
|
As i've been trying (without success) to get the pytest to succeed I'm going to close this pull request and create a new one with just the change and the revised tests - and then hopefully someone will be able to advise on how to overcome the failing inv.H3 test (all the other inverter model tests are ok?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Peak Shaving work mode in the select for H3 set Inverters & H1 (Gen 2)
See #699