KH firmware pre_133 does not support BMS registers #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, it would be worth finding what PR added this - it was obviously deliberate. I wonder whether we need to split PRE113 up further |
|
Stupidly I added it as an amendment to my H1 G2 BMS registers, it came from the KH133 thread / where users said it supported it - I won’t take anyones word unless I double check next time… It doesn’t need splitting up further, 1.33 is where the fork occurred and v1.12.2 worked ok pre 133 - this just needs reverting so that PRE133 is as it was in v1.12.2 |
|
Cool, I'll take your word for it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #772