Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix set_orcid_creators #170

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

RobLBaker
Copy link
Member

set_orcid_creators was having issues when there were some existing authors with orcids and some without. Fixed that.

closes #169

@RobLBaker RobLBaker added the bug Something isn't working label Nov 7, 2024
@RobLBaker RobLBaker self-assigned this Nov 7, 2024
Copy link
Collaborator

@wright13 wright13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RobLBaker RobLBaker merged commit c579457 into nationalparkservice:main Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_creator_orcids sometimes inadvertently provides errors/warnings
2 participants