Skip to content

Invisibly return reference URL from create_datastore_script #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Invisibly return reference URL from create_datastore_script #135

merged 2 commits into from
May 16, 2025

Conversation

wright13
Copy link
Collaborator

No description provided.

@wright13 wright13 requested a review from RobLBaker May 16, 2025 20:10
RobLBaker
RobLBaker approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@RobLBaker RobLBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but I think for some silly reason, Codefactor does not like this and dings the code rating. Not sure if we care. Maybe should just get rid of those badges all together.

@wright13
Copy link
Collaborator Author

Just changed it to invisible() instead of return(invisible()) to see if that makes it happier - I can never remember which is best practice. In any case I don't think it matters too much here.

@wright13 wright13 merged commit 2003c60 into master May 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobLBaker RobLBaker RobLBaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wright13 @RobLBaker