Skip to content

Update tags to be lowercase #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2025
Merged

Update tags to be lowercase #38

merged 2 commits into from
Apr 12, 2025

Conversation

mtmk
Copy link
Member

@mtmk mtmk commented Apr 11, 2025

fixes #37

@mtmk mtmk requested a review from caleblloyd April 11, 2025 21:08
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 92.10526% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (e003239) to head (43a8581).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/NATS.Jwt/Models/NatsTags.cs 87.50% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   79.73%   80.64%   +0.91%     
==========================================
  Files          49       51       +2     
  Lines         893      966      +73     
  Branches       81       92      +11     
==========================================
+ Hits          712      779      +67     
- Misses        155      160       +5     
- Partials       26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtmk mtmk changed the title Update tags to be case-insensitive Update tags to be lower case Apr 11, 2025
@mtmk mtmk changed the title Update tags to be lower case Update tags to be lowercase Apr 11, 2025
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@mtmk mtmk merged commit 0e7a5cd into main Apr 12, 2025
8 checks passed
@mtmk mtmk deleted the nats-tags-case-insensitive branch April 12, 2025 03:51
mtmk added a commit that referenced this pull request Apr 12, 2025
* Update tags to be lowercase (#38)
@mtmk mtmk mentioned this pull request Apr 12, 2025
mtmk added a commit that referenced this pull request Jun 20, 2025
* Update tags to be lowercase (#38)
* Make STJ conditional (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags should be converted to lowercase
2 participants