Skip to content

Make STJ conditional #40 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Make STJ conditional #40 #41

merged 1 commit into from
Jun 20, 2025

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jun 20, 2025

Closes #40

@mtmk mtmk requested a review from Copilot June 20, 2025 09:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the NATS.Jwt project file by making the inclusion of the System.Text.Json package conditional to the netstandard2.0 target framework.

  • Moves the System.Text.Json package reference into a conditional ItemGroup for netstandard2.0
  • Removes the unconditional reference from the global ItemGroup
Comments suppressed due to low confidence (1)

src/NATS.Jwt/NATS.Jwt.csproj:26

  • Moving the System.Text.Json package reference into a conditional ItemGroup ensures it’s only included for netstandard2.0. Please confirm that no other target frameworks require a direct dependency on System.Text.Json.
    <PackageReference Include="System.Text.Json" Version="8.0.5"/>

Copy link
Member

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @thompson-tomo

@mtmk
Copy link
Member

mtmk commented Jun 20, 2025

  • Moving the System.Text.Json package reference into a conditional ItemGroup ensures it’s only included for netstandard2.0. Please confirm that no other target frameworks require a direct dependency on System.Text.Json.
    <PackageReference Include="System.Text.Json" Version="8.0.5"/>

STJ is included in new .NET SDKs already. the reason we added this was due to a CVE at the time. Since SDKs are patched by now we can assume users should've installed the fixed SDKs by now.

@mtmk mtmk merged commit 4858f00 into nats-io:main Jun 20, 2025
4 checks passed
@mtmk mtmk mentioned this pull request Jun 20, 2025
mtmk added a commit that referenced this pull request Jun 20, 2025
* Update tags to be lowercase (#38)
* Make STJ conditional (#41)
@thompson-tomo thompson-tomo deleted the patch-1 branch June 20, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise dependencies based on TFM
2 participants