Skip to content

Fix handling for OnNoData when ignoring deletes #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtmk merged 1 commit into from
Apr 5, 2025
Merged

Fix handling for OnNoData when ignoring deletes #790

mtmk merged 1 commit into from
Apr 5, 2025

Conversation

@mtmk
Copy link
Member

@mtmk mtmk commented Mar 24, 2025

fixes #789

@mtmk mtmk requested a review from scottf March 24, 2025 15:25
@darkwatchuk
Copy link
Collaborator

darkwatchuk commented Mar 24, 2025

LGTM - thank you!

caleblloyd
caleblloyd approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 75d5fc1 into main Apr 5, 2025
13 checks passed
@mtmk mtmk deleted the fix-kv-watcher-no-data-with-all-deleted branch April 5, 2025 11:43
mtmk added a commit that referenced this pull request Apr 9, 2025
@mtmk
Release 2.5.14
14ea8f9 
* Fix heartbeat timer to prevent unnecessary pulls (#794)
* Inbox Subscription Memory leak .NetStandard2.0 (#803)
* Fix reader buffer bug with typo (#799)
* Fix handling for OnNoData when ignoring deletes (#790)
@mtmk mtmk mentioned this pull request Apr 9, 2025
Merged
mtmk added a commit that referenced this pull request Apr 9, 2025
@mtmk
Release 2.5.14 (#815)
c5e4e02 
* Fix heartbeat timer to prevent unnecessary pulls (#794)
* Inbox Subscription Memory leak .NetStandard2.0 (#803)
* Fix reader buffer bug with typo (#799)
* Fix handling for OnNoData when ignoring deletes (#790)
wolfkor pushed a commit to wolfkor/nats.net that referenced this pull request Apr 12, 2025
@mtmk @wolfkor
Fix handling for OnNoData when ignoring deletes (nats-io#790)
cbd67ea
This was referenced Nov 3, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

@scottf scottf Awaiting requested review from scottf

Assignees

No one assigned

Labels

in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KV.WatchAsync hangs under certain circumstances.

4 participants

@mtmk @darkwatchuk @caleblloyd