Obsolete ReplyAsync method for NatsJsMsg #839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
reviewed
Apr 24, 2025
| @@ -208,6 +208,7 @@ public NatsJSMsg(NatsMsg<T> msg, INatsJSContext context) | |||
| /// <param name="opts">A <see cref="NatsPubOpts"/> for publishing options.</param> | |||
| /// <param name="cancellationToken">A <see cref="CancellationToken"/> used to cancel the command.</param> | |||
| /// <returns>A <see cref="ValueTask"/> that represents the asynchronous send operation.</returns> | |||
| [Obsolete("ReplyAsync is not valid when using JetStream. The reply message will never reach the Requestor as NATS will reply to all JetStream publish by default.")] | |||
There was a problem hiding this comment.
just noticed actually. we have this method on the interface INatsJSMsg too
There was a problem hiding this comment.
I can include the Obsolete message on the interface too. Do you think that will be too verbose? Or just putting it on the interface would be sufficient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #834