Conversation
|
Hm, for some reason, the build fails when specifying the pkgs to build explicitly: success (old CI): @amock any idea why? I've found this commit that talks about VTK deps in lvr2. |
|
About the VTK thing: As far as I know, VTK is required only for the lvr2_viewer target, which is currently not even compiled by default. However, it is written in the "LVR2Config.cmake.in". So fixing this file would probably solve this issue. I won't be able to get to it for about 2-3 weeks. But I can accept PRs :) Edited: If VTK is really nowhere used in the lvr2 core library, it probably also can removed from the package.xml |
|
Hmm, the point where the build breaks is when a package that depends on lvr2 is being built. Then, the lvr2's I suppose we should either depend on VTK via package.xml (if a rosdep key exists for libvtk), or make this dependency truly optional (maybe it is sufficient to remove the |
|
@mklpiening @amock |
Looks good to me |
This PR changes mesh_tools to use a central reusable workflow file.
This change eases maintenance for our CI workflows, since multiple repos can now use the same workflow (before, we would need to maintain duplicated workflow files).