Skip to content

Add ability for MeshVisual to be displayed in frames different from the map frame #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

JustusBraun
Copy link
Contributor

Previously the Mesh would disappear when changing the fixed frame, now it can be displayed as expected.

@amock
Copy link
Collaborator

amock commented Apr 2, 2025

Great!

I successfully tested it with mesh geometries published via a topic using https://github.com/amock/mesh_msgs_examples along with a static transform publisher. However, meshes loaded directly from a file still can't be transformed correctly.

That said, I'm fine with merging this as it is an improvement already.

@JustusBraun
Copy link
Contributor Author

I added the ability to transform MapDisplays, and you can also select the reference frame of a map loaded from file. Also I noticed that the map would not be retransformed when the transform between the fixed frame and the map frame changed e.g. map to odom transform. This is now also fixed and working

@amock
Copy link
Collaborator

amock commented Apr 2, 2025

Works on my machine :D Ubuntu 24, ROS 2 jazzy

@amock
Copy link
Collaborator

amock commented Apr 3, 2025

Works on my other machine. Ubuntu 22, ROS 2 humble (Laptop)

@amock
Copy link
Collaborator

amock commented Apr 3, 2025

Works on my other machine: Ubuntu 22, ROS 2 humble (desktop PC)

@amock amock self-requested a review April 3, 2025 10:32
@amock amock merged commit 8bfd749 into naturerobots:humble Apr 3, 2025
1 check passed
@JustusBraun JustusBraun deleted the feature/mesh-frame-transform branch July 9, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants