Skip to content

Hardware culling support for meshes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

lrabius
Copy link
Contributor

@lrabius lrabius commented Apr 19, 2025

Meshes now support hardware culling for all display types and wireframe. It can be set to none, clockwise or anticlockwise.

Also hide/show meshes loaded from file is fixed.

fixed hide/show mesh loaded from file
@JustusBraun
Copy link
Contributor

When selecting a MeshGoal the culling mode is not applied in the intersection query in IntersectionHelper.cpp.

std::pair<bool, Ogre::Real> goal = Ogre::Math::intersects(ray,
vertices[indices[face_id * 3 + 0]],
vertices[indices[face_id * 3 + 1]],
vertices[indices[face_id * 3 + 2]], true, true);

If there is a way to query the CullingMode from the input ManualObject this would be a nice addition :)

@amock amock self-assigned this Apr 22, 2025
@amock amock self-requested a review April 22, 2025 13:09
@amock amock merged commit 347eda3 into naturerobots:humble Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants