Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nson benchmarks #142

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Fix nson benchmarks #142

merged 1 commit into from
Sep 8, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 8, 2024

Based on https://100go.co/89-benchmarks/ guide, we have to take some action to get an accurate benchmark. I updated these benchmarks to have a better result.

@fiatjaf fiatjaf merged commit b7c79c9 into nbd-wtf:master Sep 8, 2024
1 check passed
@kehiy
Copy link
Contributor Author

kehiy commented Sep 8, 2024

Also, it would be good if someone runs the benchmarks on the same device again to have a comparison. (I don't know how much these two hardware differ, to be honest)

@fiatjaf
Copy link
Collaborator

fiatjaf commented Sep 8, 2024

Thank you. I'll accept this for historical reasons, but I'm thinking about removing nson and the binary encoding from this repo, since they're not really a Nostr standard (and shouldn't be), and move the binary stuff to eventstore which is the only other library using them.

@kehiy
Copy link
Contributor Author

kehiy commented Sep 8, 2024

@fiatjaf Cool, that's a good idea and I agree with it. we can add changes to your benchmark repo as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants