feat(nix:scripts/build-time): allow builds to skip embedding build-ti… #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me.json * server doesn't require out/build-time.json to be included in embedded binary * server uses `fs.stat()` to resolve last modification made to server for build-time * using `fs.stat()` might be able to entirely resolve the build-time info that server provides to all of its different usage targets instead of needing the json version at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.stat()to resolve last modification made to server for build-timefs.stat()might be able to entirely resolve the build-time info that server provides to all of its different usage targets instead of needing the json version at allpotential fix to
nixpkgs/fish-lsp#446470