Skip to content

Add workflow step to check that packages are configured properly for CJS, ESM and older environments #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2025

Conversation

denbite
Copy link
Contributor

@denbite denbite commented Jun 4, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: 29f7d05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to NEW❗ in DevTools Jun 4, 2025
@denbite denbite self-assigned this Jun 4, 2025
@denbite denbite marked this pull request as draft June 4, 2025 20:07
@denbite
Copy link
Contributor Author

denbite commented Jun 4, 2025

these checks highlight the issue with the recently intoduced @near-js/tokens package that can't be imported on environments that have "target": "node" in their tsconfig.json

@denbite denbite marked this pull request as ready for review June 13, 2025 20:46
@denbite denbite changed the title Ensure packages are configured properly for CJS, ESM and older environments Add workflow step to check that packages are configured properly for CJS, ESM and older environments Jun 13, 2025
@denbite denbite enabled auto-merge June 13, 2025 20:51
@r-near
Copy link
Contributor

r-near commented Jun 13, 2025

We need to have #1583 merged in first

@r-near r-near force-pushed the add_check_exports_script_to_workflows branch from bce200f to c5ea61a Compare June 13, 2025 22:21
@denbite denbite merged commit d8c3022 into master Jun 15, 2025
1 check passed
@denbite denbite deleted the add_check_exports_script_to_workflows branch June 15, 2025 18:38
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

2 participants