Skip to content

fix: meta transaction was signing the incorrect payload #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

Elabar
Copy link
Contributor

@Elabar Elabar commented Jul 8, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Details

signDelegateAction was signing incorrect payload and making meta transaction failing in latest version.

Copy link

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: 88af787

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@near-js/signers Patch
@near-js/cookbook Patch
@near-js/accounts Patch
@near-js/biometric-ed25519 Patch
@near-js/client Patch
@near-js/crypto Patch
@near-js/iframe-rpc Patch
@near-js/keystores-browser Patch
@near-js/keystores-node Patch
@near-js/keystores Patch
@near-js/providers Patch
@near-js/tokens Patch
@near-js/transactions Patch
@near-js/types Patch
@near-js/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@denbite
Copy link
Contributor

denbite commented Jul 8, 2025

looks good to me, let's only include near-api-js into the changeset file as a patch

@denbite
Copy link
Contributor

denbite commented Jul 9, 2025

@Elabar I meant to add near-api-js next to @near-js/signers, not replace it

---
"near-api-js": patch
"@near-js/signers": patch
---

it's needed to explicitly add near-api-js to changesets, because whenever you upgrade one of @near-js/* packages, it doesn't trigger an update for near-api-js automatically, even though it depends on them

@Elabar
Copy link
Contributor Author

Elabar commented Jul 9, 2025

@denbite opps, sorry about that. I'm not familiar with changeset at all 🤣

I have updated it again, can you check?

@gagdiez gagdiez enabled auto-merge July 9, 2025 09:10
@gagdiez gagdiez merged commit c3f69d3 into near:master Jul 9, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools Jul 9, 2025
@github-actions github-actions bot mentioned this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

3 participants