-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add advanced-settings docs #115
Conversation
✅ Deploy Preview for nebari-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting review for advanced configuration.
Find/replace all instances of QHub that are not inside of command names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. Thanks @viniciusdc for all of this great information! You did a great job covering a ton of material!
Co-authored-by: Kim Pevey <[email protected]>
Co-authored-by: Kim Pevey <[email protected]>
Co-authored-by: Kim Pevey <[email protected]>
Co-authored-by: Kim Pevey <[email protected]>
Co-authored-by: Kim Pevey <[email protected]>
Thanks, @kcpevey I will be updating this today. |
... | ||
``` | ||
|
||
## Dask profiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a cross reference in the Dask docs back to this config. I made a note of it here .
@pavithraes is ready for another review? |
Thanks for checking in! Not yet, one more commit with some miscellaneous+minor tweaks is in progress -- I'll ping you in a day or so with that! |
@kcpevey @viniciusdc This PR isn't perfect, but please feel free to review and we can start iteratively merging sections/pages that look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pavithraes! This is a great PR. A lot of work has gone into this and its a LOT of content. I'd love to see it get merged soon!
|
||
Local deployment is intended for Nebari deployments on a "local" cluster created and management by Kind. | ||
It is great for experimentation and development. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert some comment here about Macs - @iameskild can you do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a note saying this is only supported on linux right now, like in: http://localhost:3000/docs/how-tos/nebari-local#compatibility
Let me know if you'd like to add something more. :)
@kcpevey Thanks for the review, I've made the suggested updates, ready for another round. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's merge this baby!!
Reference Issues or PRs
fixes #102
closes #103
closes #255
also,
closes #68
closes #277
closes #279
What does this implement/fix?
Put an
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?
related to #88