Skip to content

Commit

Permalink
Remove references about Rails 5, that's not supported anymore
Browse files Browse the repository at this point in the history
  • Loading branch information
markoudev committed Jan 7, 2025
1 parent f07562c commit bd8c8bc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,6 @@ by default. But it's good to be aware of this in case you're running into
weirdness.


# Known issues
* With Rails 5.0 in combination with uniqueness validations, ActiveRecord
generates a wrong query. The `x` in front of the queried value, which casts
the value to the proper data type, is missing.


# Contributing
To start coding on `mysql-binuuid-rails`, fork the project, clone it locally
and then run `bin/setup` to get up and running. If you want to fool around in
Expand Down
4 changes: 0 additions & 4 deletions test/integration/mysql_integration_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ class BeforePersistedTest < MySQLIntegrationTest
end

test "validates uniqueness" do
if ActiveRecord.version < Gem::Version.new("5.1.0")
skip("Skipping uniqueness validation test, known issue on Rails/ActiveRecord 5.0")
end

uuid = SecureRandom.uuid
MyUuidModelWithValidations.create!(the_uuid: uuid)
duplicate = MyUuidModelWithValidations.new(the_uuid: uuid)
Expand Down

0 comments on commit bd8c8bc

Please sign in to comment.