fix resolution warnings

neffo · Mar 19, 2024 · 73d7812 · 73d7812
1 parent 6fd4a0d
commit 73d7812
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/locale/BingWallpaper.pot b/locale/BingWallpaper.pot
@@ -1,5 +1,5 @@
-#: ui/prefsadw.ui.h:1
-msgid "Members"
+#: ui/prefsadw.ui.h:1 extension.js:139
+msgid "Settings"
 msgstr ""
 
 #: ui/prefsadw.ui.h:2
@@ -51,7 +51,7 @@ msgid "Whether to set wallpaper automatically"
 msgstr ""
 
 #: ui/prefsadw.ui.h:14
-msgid "Enabled shuffle"
+msgid "Shuffle wallpaper"
 msgstr ""
 
 #: ui/prefsadw.ui.h:15
@@ -298,10 +298,6 @@ msgstr ""
 msgid "Refresh Now"
 msgstr ""
 
-#: extension.js:139
-msgid "Settings"
-msgstr ""
-
 #: extension.js:140
 msgid "Open in image viewer"
 msgstr ""

diff --git a/prefs.js b/prefs.js
@@ -285,7 +285,9 @@ export default class BingWallpaperExtensionPreferences extends ExtensionPreferen
         });
         resolutionEntry.set_model(resolutionModel);
 
-        settings.bind('resolution', resolutionEntry, 'selected', Gio.SettingsBindFlags.DEFAULT);
+        settings.connect('changed::resolution', () => {
+            resolutionEntry.set_selected(Utils.resolutions.map( e => e.value).indexOf(settings.get_string('resolution')));
+        });
 
         settings.connect('changed::resolution', () => {
             Utils.validate_resolution(settings);

diff --git a/ui/prefsadw.ui b/ui/prefsadw.ui
@@ -24,7 +24,7 @@ Bing Wallpaper GNOME extension by: Michael Carroll
     <requires lib="libadwaita" version="1.0"/>
     <object class="AdwPreferencesPage" id="settings_page">
         <property name="icon-name">emblem-photos-symbolic</property>
-        <property name="title" translatable="yes">Members</property>
+        <property name="title" translatable="yes">Settings</property>
         <child>
             <object class="AdwPreferencesGroup" id="ui_group">
                 <property name="title" translatable="yes">Indicator</property>
@@ -85,7 +85,7 @@ Bing Wallpaper GNOME extension by: Michael Carroll
                 </child>
                 <child>
                     <object class="AdwSwitchRow" id="shuffleSwitch">
-                        <property name="title" translatable="yes">Enabled shuffle</property>
+                        <property name="title" translatable="yes">Shuffle wallpaper</property>
                         <property name="subtitle" translatable="yes">Randomly select wallpaper from collection</property>
                     </object>
                 </child>