Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Blur/dimming not applied on lock screen #239

Open
IBBoard opened this issue Jun 2, 2024 · 3 comments
Open

[BUG] Blur/dimming not applied on lock screen #239

IBBoard opened this issue Jun 2, 2024 · 3 comments
Labels

Comments

@IBBoard
Copy link
Contributor

IBBoard commented Jun 2, 2024

Describe the bug
When setting the lockscreen wallpaper with dynamic lockscreen blur, no dimming or blur is applied. The image is show as-is. This can make it hard to see the password prompt etc.

Screenshots
image

To Reproduce
Steps to reproduce the behavior:

  1. Install extension
  2. Go to settings
  3. Toggle "Dynamic lockscreen blur" to "On"
  4. Click a Preset button
  5. Lock screen with Super+L
  6. Click to bring up the password prompt

Desktop (please complete the following information):

  • OS: openSUSE Tumbleweed
  • Extension Version: 49
  • GNOME Version: 46.2
  • Other extensions
    • App Indicator Support
    • Smart Auto Move

Additional context
I've been using the plugin for a while. This used to work but stopped a while back. Possibly around the time there was the rewrite for new Gnome compatibility.

I tried uninstalling it, wiping all of the settings with dconf reset -f /org/gnome/shell/extensions/bingwallpaper/ and re-installing in case it was a "legacy install" issue, but there's no change.

If I've got dconf-editor open while I change presets then it prompts me to reload and the settings are changed. But if I edit blur.js to enable debug logging (because it's not on the main toggle) then it only logs BingWallpaper extension/Blur: lockscreen blur strength set to 0 when switching between "default" and "No blur/slight dimming", and then logs BingWallpaper extension/Blur: lockscreen blur strength set to 0 and BingWallpaper extension/Blur: lockscreen brightness set to 65 when switching between "Slight blur & dim" and the other two.

@IBBoard IBBoard added the bug label Jun 2, 2024
@IBBoard
Copy link
Contributor Author

IBBoard commented Jun 2, 2024

I added some extra logging into _updateBackgroundEffects_BWP() and it definitely gets a value in effect. And it's passing the expected values. But I've not worked out whether it's getting the right widget or whether something weird is happening and it's blurring the wrong thing.

@IBBoard
Copy link
Contributor Author

IBBoard commented Jun 2, 2024

I've been poking around in the script and trying to debug more. The control-blur-effect-on-lockscreen extension seems to work okay.

Looking at their source code, it looks like it gets the widgets in a different way and then Gnome 46 changed the blur settings.

So far, I've only managed to make everything lock up and not show the lock screen when I edit the Bing Wallpaper code, though 😁

@IBBoard
Copy link
Contributor Author

IBBoard commented Jul 12, 2024

I think I've got a fix for this now. I just need to tidy up a few bits (in particular, it doesn't seem to apply new settings until the second time that you lock!)

neffo added a commit that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant