Bug #239: fix lockscreen dimming #240
Conversation
JavaScript was evaluatinig string+func as bool for the ternary rather than appending the ternary
Re-applying the same value is harmless, so use the `_setBlur` function to ensure we have the current value
We connect to setting change events, but never disconnect. Destroying the object doesn't disconnect the events. Disabling and re-enabling the extension then caused repeated updates. And locking and unlocking the screen caused the extension to be disabled and re-enabled. We now clean up the setting events when the object gets destroyed.
|
There may be a bug in this that I need to track down. I've not worked out when. But sometimes it seems to use some default settings for the blur. I have it set for a slight blur, but sometimes when I wake the monitor and unlock it then I see a strong blur. But at least it is blurring, so the prompts are easier to see 🙂 |
|
Thanks for looking into this, and yeah this has been a cause of some problems for a while. There is a bit of inconsistent behavior happening in the existing code which I never tracked down (seemed to trigger when recovering from standby as you note). I suspected this might be due to something that GNOME was doing during that state change, but I'll grant this code is ugly. Other extensions do this in other ways, but trying to tap into the state change of password entry is maybe unique? I think this is key to making it usable though. |
|
After running this for a while, it's not 100% consistent, but it sometimes seems to go for a heavy blur, and it seems to be when I have to wake my monitor up (e.g. I've left my PC along for an hour or more). It's not every time. And it's not related to hibernating (the PC is still on, it's just the monitor going into power saving and then turning itself off). It could be a race condition during the wake up. But the next lock after that has the right blur. And too much blur is better for readability than not enough blur, so I'm accepting the compromise for now 🙂 |
|
Yeah I had similar problems trying to debug this, not clear why it wasn't inconsistent. Are you ready to merge it? |
|
I've not put in logging to chase it down yet. You could merge it if you want, because I think "mostly gets the right dimming/blur" is better than "rarely gets it right". But I don't mind if you'd rather wait until the bug is fixed as well. |
|
There's no rush, I just want to put out a version to support the new GNOME version with whatever is fixed. I've not tested your branch yet myself, but obviously appreciate the effort you've put into it and would be keen to merge when you are happy with it. (It can be merged whenever.) |
|
If you want a version for Gnome support then merge this and I'll work on the the occasional default blur levels separately. |
I think I've managed to fix the lockscreen dimming (#239) and some related issues.
The commit messages have more detail, but basically:
I'm running this locally and I haven't seen any issues yet.