bug+feature: Lockscreen blur bugfix + add support for transition #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG:
On the lockscreen, when switching between clock and login prompt, the blur and brightness did not change to gnome defaults but stayed at the values set by the extension. (I tried several settings for blur and brightness, including all the presets.)
Step by step:
Expect blur to change in last step, but doesn't.
BUGFIX: first commit
In journal, I saw that
Blur._disable()
is called when locking, andBlur._enable()
when unlocking the screen. To prevent this disabling of the extension on the lockscreen, I added"session-modes": ["user", "unlock-dialog"]
to metadata.json.FEATURE: second commit
changed
setTransitionProgress
to also update blur and brightness in the transition animation.this may require further testing on other OS/Gnome versions.
everything done (and only tested) on