Skip to content

bug+feature: Lockscreen blur bugfix + add support for transition #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: version-52
Choose a base branch
from

Conversation

engel-lucas
Copy link

BUG:

On the lockscreen, when switching between clock and login prompt, the blur and brightness did not change to gnome defaults but stayed at the values set by the extension. (I tried several settings for blur and brightness, including all the presets.)

Step by step:

  • enable dynamic lockscreen blur
  • restart gnome-shell (alt+f2, r, enter)
  • lock screen (super+L, or via top bar settings)
  • scroll down (reveals login prompt)
    Expect blur to change in last step, but doesn't.

BUGFIX: first commit

In journal, I saw that Blur._disable() is called when locking, and Blur._enable() when unlocking the screen. To prevent this disabling of the extension on the lockscreen, I added "session-modes": ["user", "unlock-dialog"] to metadata.json.

FEATURE: second commit

changed setTransitionProgress to also update blur and brightness in the transition animation.
this may require further testing on other OS/Gnome versions.

everything done (and only tested) on

  • Ubuntu 24.04
  • Gnome 46.0
  • Extension commit 074cda6

@neffo neffo changed the base branch from master to version-51 March 15, 2025 14:05
@neffo neffo changed the base branch from version-51 to version-52 March 22, 2025 11:00
@neffo
Copy link
Owner

neffo commented Mar 22, 2025

Thanks, just switched this to point to v52 branch.

Sorry I didn't have enough time to test this for introduction in v51.

@neffo
Copy link
Owner

neffo commented Mar 22, 2025

Can we detect the current session mode? Ideally we'd want to disable the main extension during lockscreen and only enable the blur component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants