Ingest waits for delays from s3 #1483
Merged
+38
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahatz
previously approved these changes
Mar 20, 2025
jbygdell
reviewed
Mar 21, 2025
MalinAhlberg
force-pushed
the
fix/ingest-waits-for-s3
branch
2 times, most recently
from
b4b979e to
496df2d
Compare
jbygdell
approved these changes
Mar 21, 2025
leaving time for s3 to complete writing, when file is just uploaded
MalinAhlberg
force-pushed
the
fix/ingest-waits-for-s3
branch
from
496df2d to
bf5f2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #1430 .
Description
Ingest needs the
GetFileSizeto accept some delay from s3, so that it does not immediately fail when receivingNoSuchKeyorNotFound. At other points, however, this extra waiting time is not wanted, for example when calling the function fromverify, since that would give 2 minutes extra waiting time before the call fails (if the file is not present in the storage). Notably, this test would require a lot of retries.My assumption is that it should be optional whether a delay from s3 should be expected or not.
This PR therefore adds an extra parameter to allow for this.
If you have other ideas, please feel very welcome to post them here.
How to test
Make sure all tests pass. You could also mock this call so that it does not find the queried file at once.