Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/database] add test step to append files to a dataset. #1507

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

jbygdell
Copy link
Collaborator

Related issue(s) and PR(s)

This PR closes #1503.

Description

This adds a missing step for appending files to a dataset in the MapFilesToDataset DB call.

How to test

@jbygdell jbygdell requested a review from a team March 20, 2025 14:10
@jbygdell jbygdell self-assigned this Mar 20, 2025
MalinAhlberg
MalinAhlberg previously approved these changes Mar 24, 2025
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that you can add more files to a dataset already.

However, it would be nice to have something like

      {
         "role": "submission",
         "path": "/dataset/*",
         "action": "POST"
       }

in .github/integration/sda/rbac.json so that this is easier to test manually.

@jbygdell jbygdell force-pushed the tests/expand-dataset-mapping-tests branch 2 times, most recently from 425a07d to d5ec7c1 Compare March 26, 2025 10:46
@jbygdell jbygdell force-pushed the tests/expand-dataset-mapping-tests branch from d5ec7c1 to 47bd1a2 Compare March 31, 2025 12:13
@jbygdell jbygdell added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 816cc5f Mar 31, 2025
29 checks passed
@jbygdell jbygdell deleted the tests/expand-dataset-mapping-tests branch March 31, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mapper] Mapper should be able to add files to an already existing dataset
3 participants