lgtm-cat-processerのLambdaに環境変数を追加 #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
changed the title
keitakn
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#115
Doneの定義
#115 の完了の定義が満たされていること
変更点概要
lgtm-cat-processorのLambdaに以下の環境変数を追加
DBへの接続情報はLambdaの環境変数に設定するとAWSコンソールから閲覧できてしまうため、アプリケーション上でSecrets Managerから取得することも検討したが、最終的には環境変数に設定する形を選択した。その理由としては、開発者が2人のみであり、Lambda上から接続情報が確認できたとしても、大きなセキュリティリスクにはならないと判断したため。
また、Issueとは関係ないがリソースの名前に
--となってしまっている箇所があったので修正を行った。IAM role,policy名がハイフンが重なってしまっていたので修正
レビュアーに重点的にチェックして欲しい点
機密情報の扱いについて認識としてずれてないか。