lgtm-cat-processerのLambdaにS3の権限を付与 #118
Merged
+47
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
force-pushed
the
feature/issue117
branch
from
8946ec5 to
f089943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#117
Doneの定義
#117 の完了の定義が満たされていること
変更点概要
LambdaがS3バケットからファイルダウンロード、S3へのアップロードができるように以下の変更を行った。
LambdaのIAM RoleにS3へのアクションを許可するためのカスタマーインラインpolicyを追加
Issueとは関係ないが、module側でリソースIDを定義した方が可読性が高くなり、moduleに渡す変数も減らすことで意図しないリソースIDをつけてしまうミスを減らせると思い下記のリファクタリングを行った。
リソースIDをmodule側で定義するようにリファクタリング
レビュアーに重点的にチェックして欲しい点
リファクタリングの観点に問題がないかどうかレビューお願いします。