Skip to content

lgtm-cat-processor StepFunctinsステートマシンからWebP変換処理用のタスクを削除 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

kobayashi-m42
Copy link
Member

issueURL

#121

Doneの定義

#121 の完了の定義を満たしていること

変更点概要

lgtm-cat-processor StepFunctinsステートマシンからWebP変換処理用のタスクを削除。
上記に伴い、LGTM画像生成時にアップロード先のS3ファイルも変更。

@@ -5,6 +5,5 @@ locals {
log_retention_in_days = 3
upload_images_bucket = "${local.env}-lgtmeow-cat-images"
judge_image_upload_bucket = "${local.env}-lgtmeow-cat-images"
generate_lgtm_image_upload_bucket = "${local.env}-lgtmeow-created-lgtm-images"
convert_to_webp_upload_bucket = "${local.env}-lgtmeow-images"
generate_lgtm_image_upload_bucket = "${local.env}-lgtmeow-images"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM画像(WebP形式)をアップロードするためのS3バケットに変更

@kobayashi-m42 kobayashi-m42 marked this pull request as ready for review September 13, 2024 11:07
@kobayashi-m42 kobayashi-m42 self-assigned this Sep 13, 2024
Copy link
Member

@keitakn keitakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとう🐱👍

LGTMeow

@kobayashi-m42 kobayashi-m42 merged commit 5242344 into main Sep 13, 2024
1 check passed
@kobayashi-m42 kobayashi-m42 deleted the feature/issue121 branch September 13, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants