Skip to content

Remove unused dependency to aws-lc-rs #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Remove unused dependency to aws-lc-rs #250

merged 2 commits into from
Jul 21, 2025

Conversation

madchicken
Copy link
Collaborator

This PR should fix #249

Copy link
Collaborator

@knutwalker knutwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Could you also look into #249 (comment) ?
If not, I can sort this out sometime this week and we can merge this one before.

@madchicken
Copy link
Collaborator Author

@knutwalker, I have set default-features = false for rustls, although I could not test the build on Windows.

@knutwalker
Copy link
Collaborator

I'm ok with merging. I could test a windows build later if you want, but feel free to merge ahead of that.

@madchicken madchicken merged commit 4962195 into main Jul 21, 2025
11 checks passed
@madchicken madchicken deleted the remove-unused-dep branch July 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lc-rs dependency in release candidates
2 participants